Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Include the dashboard in Windows wheels #19575

Merged
merged 5 commits into from
Oct 23, 2021

Conversation

pcmoritz
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz
Copy link
Contributor Author

I just tested the wheel I pushed to test wheels (e.g. the one for 3.7 is under https://s3-us-west-2.amazonaws.com/ray-wheels/test_wheels/windows_dashboard/680fee7d019c711ce639f3e7c8d2a72f465d667e/ray-2.0.0.dev0-cp37-cp37m-win_amd64.whl) and the dashboard is running now 🥳

@pcmoritz pcmoritz changed the title [Dashboard] Build the dashboard on Windows [Dashboard] Include the dashboard in Windows wheels Oct 23, 2021
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI is happy

Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI is happy

@pcmoritz
Copy link
Contributor Author

The CI is not only happy, but even exhilarated about this change 😂

@carlogrisetti
Copy link
Contributor

Yayyyy! I can finally see the dashboard in windows, and it's nice :)
(also the experimental one works)

@kk-55
Copy link
Contributor

kk-55 commented Nov 8, 2021

Yayyyy! I can finally see the dashboard in windows, and it's nice :) (also the experimental one works)

@carlogrisetti what did you do that it is working for you now?
I tried to install the wheel for 3.8 but I can't see the dashboard (still connection refused error).

@carlogrisetti
Copy link
Contributor

Where did you get the wheel from?
Are you trying to access the dashboard on the same machine is it running from?

@kk-55
Copy link
Contributor

kk-55 commented Nov 8, 2021

@carlogrisetti solved
I completely removed ray and did a new install of ray with the proposed wheel

I just tested the wheel I pushed to test wheels (e.g. the one for 3.7 is under https://s3-us-west-2.amazonaws.com/ray-wheels/test_wheels/windows_dashboard/680fee7d019c711ce639f3e7c8d2a72f465d667e/ray-2.0.0.dev0-cp37-cp37m-win_amd64.whl) and the dashboard is running now 🥳

Thanks anyway!

@carlogrisetti
Copy link
Contributor

@kk-55 Nice :)

@19greg96
Copy link

Should this work in 1.8.0? I tried with the wheels for 3.7 and 3.8, (ray 1.8.0) but I still get connection reset. Installing the aforementioned ray-2.0.0.dev0 wheel works.

note: I use conda on windows to create virtual environments, and use pip to install packages. Dashboard directory still missing the client directory with the 1.8.0 release.

@carlogrisetti
Copy link
Contributor

I had some issues (albeit different) with the prepackaged distribution. Using the latest "nightly" wheel it all works fine.
I suppose something was missing from the official stable release, but I suppose it will be present in the next one.

@19greg96
Copy link

Great, thanks! I'm looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants