-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Include the dashboard in Windows wheels #19575
[Dashboard] Include the dashboard in Windows wheels #19575
Conversation
I just tested the wheel I pushed to test wheels (e.g. the one for 3.7 is under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as CI is happy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as CI is happy
The CI is not only happy, but even exhilarated about this change 😂 |
Yayyyy! I can finally see the dashboard in windows, and it's nice :) |
@carlogrisetti what did you do that it is working for you now? |
Where did you get the wheel from? |
@carlogrisetti solved
Thanks anyway! |
@kk-55 Nice :) |
Should this work in 1.8.0? I tried with the wheels for 3.7 and 3.8, (ray 1.8.0) but I still get connection reset. Installing the aforementioned ray-2.0.0.dev0 wheel works. note: I use conda on windows to create virtual environments, and use pip to install packages. Dashboard directory still missing the client directory with the 1.8.0 release. |
I had some issues (albeit different) with the prepackaged distribution. Using the latest "nightly" wheel it all works fine. |
Great, thanks! I'm looking forward to it. |
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.