[RLlib; Docs overhaul] Docstring cleanup: Evaluation #19783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
reviewed
Oct 27, 2021
| @@ -200,29 +242,55 @@ def last_action_for(self, | |||
| @DeveloperAPI | |||
| def prev_action_for(self, | |||
| agent_id: AgentID = _DUMMY_AGENT_ID) -> EnvActionType: | |||
| """Returns the previous action for the specified agent.""" | |||
| """Returns the previous action for the specified agent, or zeros. | |||
There was a problem hiding this comment.
actually what's the diff between last_action_for and prev_action_for?
There was a problem hiding this comment.
Good question:
last_action = action taken most recently by agent X.
prev_action = action taken one before the most recent one by agent X.
I'll add this explanation. ...
…_docstring_cleanup_evaluation # Conflicts: # rllib/agents/callbacks.py # rllib/policy/policy.py # rllib/policy/tf_policy.py
…_docstring_cleanup_envs # Conflicts: # rllib/agents/callbacks.py
…_docstring_cleanup_evaluation
…_docstring_cleanup_evaluation # Conflicts: # rllib/agents/callbacks.py # rllib/evaluation/rollout_worker.py # rllib/evaluation/worker_set.py
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Oct 29, 2021
…ject#19783)" This reverts commit 9c73871.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstring cleanup: rllib/evaluation folder.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.