Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Script for building M1 wheels #19925

Merged
merged 4 commits into from
Nov 1, 2021
Merged

[ci] Script for building M1 wheels #19925

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8281840
[ci] Script for building M1 wheels
wuisawesome Oct 31, 2021
f3c18da
Update build-wheel-macos-m1.sh
Oct 31, 2021
a97b4c4
lint
Nov 1, 2021
1756373
Rename build-wheel-macos-m1.sh to build-wheel-macos-arm64.sh
Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions python/build-wheel-macos-m1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ set -e
# Show explicitly which commands are currently running.
set -x

# Much of this is taken from https://github.com/matthew-brett/multibuild.
# This script uses "sudo", so you may need to type in a password a couple times.

MACPYTHON_URL=https://www.python.org/ftp/python
MACPYTHON_PY_PREFIX=/Library/Frameworks/Python.framework/Versions
DOWNLOAD_DIR=python_downloads

NODE_VERSION="14"
Expand All @@ -20,7 +15,7 @@ PY_MMS=("3.8"
"3.9")


if ![[ -z "${SKIP_DEP_RES}" ]]; then
if [[ -n "${SKIP_DEP_RES}" ]]; then
./ci/travis/install-bazel.sh

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
Expand All @@ -45,7 +40,7 @@ mkdir -p .whl

for ((i=0; i<${#PY_VERSIONS[@]}; ++i)); do
PY_MM=${PY_MMS[i]}
CONDA_ENV_NAME=p$PY_MM
CONDA_ENV_NAME="p$PY_MM"

# The -f flag is passed twice to also run git clean in the arrow subdirectory.
# The -d flag removes directories. The -x flag ignores the .gitignore file,
Expand All @@ -55,10 +50,10 @@ for ((i=0; i<${#PY_VERSIONS[@]}; ++i)); do

# Install python using conda. This should be easier to produce consistent results in buildkite and locally.
source ~/.bash_profile
conda create -y -n $CONDA_ENV_NAME
conda activate $CONDA_ENV_NAME
conda create -y -n "$CONDA_ENV_NAME"
conda activate "$CONDA_ENV_NAME"
conda remove -y python || true
conda install -y python=$PY_MM
conda install -y python="$PY_MM"

# NOTE: We expect conda to set the PATH properly.
PIP_CMD=pip
Expand All @@ -84,7 +79,6 @@ for ((i=0; i<${#PY_VERSIONS[@]}; ++i)); do
TRAVIS_COMMIT=$(git rev-parse HEAD)
fi

echo $TRAVIS_COMMIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not keep this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i mean i guess we could, it was just an accidental debugging print statement i left in.

(note we are already printing echo "TRAVIS_COMMIT variable detected. ray.__commit__ will be set to $TRAVIS_COMMIT")

sed -i .bak "s/{{RAY_COMMIT_SHA}}/$TRAVIS_COMMIT/g" ray/__init__.py && rm ray/__init__.py.bak

# Add the correct Python to the path and build the wheel. This is only
Expand Down