Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; Docs] Updated RLlib training example page #19932

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

worldveil
Copy link
Contributor

This updates the RLlib training docs page to stop users from running into errors when running examples.

Added some pip install ... to help. Still running into this error, though:

% rllib train --env=PongDeterministic-v4 --run=A2C --config '{"num_workers": 8}'
Traceback (most recent call last):
  File "/Users/will/opt/anaconda3/envs/ray-docs/bin/rllib", line 5, in <module>
    from ray.rllib.scripts import cli
  File "/Users/will/opt/anaconda3/envs/ray-docs/lib/python3.7/site-packages/ray/rllib/__init__.py", line 5, in <module>
    from ray.rllib.env.base_env import BaseEnv
  File "/Users/will/opt/anaconda3/envs/ray-docs/lib/python3.7/site-packages/ray/rllib/env/__init__.py", line 1, in <module>
    from ray.rllib.env.base_env import BaseEnv
  File "/Users/will/opt/anaconda3/envs/ray-docs/lib/python3.7/site-packages/ray/rllib/env/base_env.py", line 3, in <module>
    from ray.rllib.env.external_env import ExternalEnv
  File "/Users/will/opt/anaconda3/envs/ray-docs/lib/python3.7/site-packages/ray/rllib/env/external_env.py", line 7, in <module>
    from ray.rllib.utils.annotations import PublicAPI
  File "/Users/will/opt/anaconda3/envs/ray-docs/lib/python3.7/site-packages/ray/rllib/utils/__init__.py", line 10, in <module>
    from ray.rllib.utils.numpy import sigmoid, softmax, relu, one_hot, fc, lstm, \
  File "/Users/will/opt/anaconda3/envs/ray-docs/lib/python3.7/site-packages/ray/rllib/utils/numpy.py", line 2, in <module>
    import tree
ModuleNotFoundError: No module named 'tree'

@sven1977 sven1977 self-assigned this Nov 2, 2021
@sven1977 sven1977 changed the title Updated RLlib training example page [RLlib; Docs] Updated RLlib training example page Nov 2, 2021
@@ -56,6 +57,7 @@ An example of evaluating a previously trained DQN policy is as follows:

.. code-block:: bash

pip install gym
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't gym come with pip install ray[rllib]?

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fixes. Just one question on the additional gym installation.

@worldveil
Copy link
Contributor Author

OK, removed. Let's merge?

@sven1977 sven1977 merged commit f359b21 into master Nov 3, 2021
@sven1977 sven1977 deleted the rllib-training branch November 3, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants