Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Rename backend tag -> deployment name #19997

Merged
merged 2 commits into from
Nov 3, 2021
Merged

[serve] Rename backend tag -> deployment name #19997

merged 2 commits into from
Nov 3, 2021

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Nov 2, 2021 •
edited
Loading

Why are these changes needed?

Related issue number

#19149

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

simon-mo
simon-mo approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp. Interesting choice from tag -> name?

@edoakes edoakes merged commit e1e0cb5 into ray-project:master Nov 3, 2021
@edoakes
Copy link
Contributor Author

edoakes commented Nov 3, 2021

Tag doesn't really mean anything, name matches the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edoakes @simon-mo