Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Fix PTL tutorial docs #19999

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Nov 2, 2021

Our tutorial for PTL is outdated: #19988

This updates the tutorial by pulling code snippets from the actual example in the docs instead of including the code snippets directly.

Closes #19988

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@xwjiang2010 xwjiang2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amog!

@richardliaw richardliaw merged commit f67b526 into ray-project:master Nov 4, 2021
@amogkam amogkam mentioned this pull request Nov 4, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue on page /tune/tutorials/tune-pytorch-lightning.html
3 participants