[serve] Rename backend_state -> deployment_state #20040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
architkulkarni
approved these changes
Nov 3, 2021
| @@ -963,9 +965,9 @@ def _scale_backend_replicas(self) -> bool: | |||
|
|
|||
| def _check_curr_goal_status(self) -> GoalStatus: | |||
| """ | |||
| In each update() cycle, upon finished calling _scale_all_backends(), | |||
| In each update() cycle, upon finished calling _scale_all_deployments(), | |||
There was a problem hiding this comment.
Let's also change the actual function name if we haven't already
|
mac wheel build failing on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
#19149
Checks
scripts/format.shto lint the changes in this PR.