[RLlib] Minor cleanups in Trainer; better tf/tf2 info messages about possible tracing speedups.
#20109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
changed the title
Trainer; metter tf/tf2 info messages about possible tracing speedups.Trainer; better tf/tf2 info messages about possible tracing speedups.
gjoliver
approved these changes
Nov 5, 2021
rllib/agents/trainer.py
Outdated
| self.env_creator = _global_registry.get(ENV_CREATOR, env) | ||
| # A class specifier. | ||
| elif "." in env: | ||
| if _global_registry.contains(ENV_CREATOR, self._env_id): |
There was a problem hiding this comment.
maybe worth breaking everything in this if statement into a little util function, so things don't look so nested here.
| "(framework='tf')") | ||
| # Tf-static-graph (framework=tf): Recommend upgrading to tf2 and | ||
| # enabling eager tracing for similar speed. | ||
| elif tf1 and self.config["framework"] == "tf": |
There was a problem hiding this comment.
haha, maybe we can say this in a more "recommendation" manner, since this user is specifically asking for tf1 here? something like:
You are using tensorflow static-graph mode. Consider setting framework='tf2' to upgrade to tf2.x eager execution, and eager_tracing=True to reach similar execution speed as static-graph mode.
Just a suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups in
Trainer; metter tf/tf2 info messages about possible tracing speedups.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.