[DOC] Fixed a broken code snippet with a missing method #20130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jules S.Damji <[email protected]>
sasha-s
reviewed
Nov 6, 2021
| @@ -652,9 +652,17 @@ Actor Pool | |||
|
|
|||
| from ray.util import ActorPool | |||
|
|
|||
| @ray.remote | |||
sasha-s
approved these changes
Nov 6, 2021
rkooo567
approved these changes
Nov 7, 2021
|
@richardliaw @sven1977 are these snippet running in CI? |
|
Thanks team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jules S.Damji [email protected]
Why are these changes needed?
The code snippet to demonstrate how to use ActorPool is broken because a) Actor method
double()is missing and b) ActoorPool.map returns a generator. To print the values you have to iterate over.This PR fixes it and makes it work. Having code snippets that demonstrably work is a good practice as part of developer docs.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.