-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI; Tune] Split Tune tests and examples #20210
Conversation
# Because Python version changed, we need to re-install Ray here | ||
- rm -rf ./python/ray/thirdparty_files; rm -rf ./python/ray/pickle5_files; ./ci/travis/ci.sh build | ||
- bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only | ||
--test_tag_filters=tests_dir_A,tests_dir_B,tests_dir_C,tests_dir_D,tests_dir_E,tests_dir_F,tests_dir_G,tests_dir_H,tests_dir_I,tests_dir_J,tests_dir_K,tests_dir_L,tests_dir_M,tests_dir_N,tests_dir_O,tests_dir_P,-example,-flaky,-py37,-soft_imports,-gpu_only,-rllib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you instead to test_dir_A-P
and test_dir_Q-Z
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the more granular tags, so that we can easily shift load around or split more when we add more tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm with @xwjiang2010. Will make it easier later to keep this organized when as tests come aboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Let's merge it. Thanks @xwjiang2010 !
Why are these changes needed?
Split Tune tests into multiple chunks.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.