Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI; Tune] Split Tune tests and examples #20210

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Nov 10, 2021

Why are these changes needed?

Split Tune tests into multiple chunks.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010 xwjiang2010 changed the title Split Tune tests and examples part 1 into tests and examples separate. Split Tune tests and examples Nov 10, 2021
@xwjiang2010 xwjiang2010 changed the title Split Tune tests and examples [CI] Split Tune tests and examples Nov 10, 2021
@xwjiang2010 xwjiang2010 added this to the Tune Tech Debt Reduction milestone Nov 10, 2021
@xwjiang2010 xwjiang2010 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Nov 10, 2021
# Because Python version changed, we need to re-install Ray here
- rm -rf ./python/ray/thirdparty_files; rm -rf ./python/ray/pickle5_files; ./ci/travis/ci.sh build
- bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only
--test_tag_filters=tests_dir_A,tests_dir_B,tests_dir_C,tests_dir_D,tests_dir_E,tests_dir_F,tests_dir_G,tests_dir_H,tests_dir_I,tests_dir_J,tests_dir_K,tests_dir_L,tests_dir_M,tests_dir_N,tests_dir_O,tests_dir_P,-example,-flaky,-py37,-soft_imports,-gpu_only,-rllib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you instead to test_dir_A-P and test_dir_Q-Z?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the more granular tags, so that we can easily shift load around or split more when we add more tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with @xwjiang2010. Will make it easier later to keep this organized when as tests come aboard.

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Let's merge it. Thanks @xwjiang2010 !

@sven1977 sven1977 changed the title [CI] Split Tune tests and examples [CI; Tune] Split Tune tests and examples Nov 11, 2021
@sven1977 sven1977 merged commit 883fbd0 into ray-project:master Nov 11, 2021
@xwjiang2010 xwjiang2010 deleted the split branch November 11, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants