-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib; documentation] "RLlib in 60sec" overhaul. #20215
[RLlib; documentation] "RLlib in 60sec" overhaul. #20215
Conversation
…_rllib_in_60sec_overhaul
…_rllib_in_60sec_overhaul
@@ -318,8 +318,9 @@ Papers | |||
:maxdepth: -1 | |||
:caption: Ray RLlib | |||
|
|||
rllib.rst | |||
rllib/index.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will start moving all rllib docs files into the rllib
sub-folder to the rst's will no longer be in the top-leve directory. Analogous to how tune docs do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
@@ -0,0 +1,195 @@ | |||
.. admonition:: We're hiring! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new RLlib main index page.
@@ -40,6 +40,10 @@ | |||
# starting letter of the test name (e.g. "examples_A", or "tests_dir_F") for | |||
# split-up purposes in buildkite. | |||
|
|||
# Note: There is a special directory in examples: "documentation" which contains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start CI-testing any code snippet in the RLlib documentation.
@@ -749,8 +749,9 @@ def env_creator_from_classpath(env_context): | |||
# Evaluation setup. | |||
self.evaluation_workers = None | |||
self.evaluation_metrics = {} | |||
# Do automatic evaluation from time to time. | |||
if self.config.get("evaluation_interval"): | |||
# User would like to setup a separate evaluation worker set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change in the code to make the new example (RLlib in 60s) work with fewer config-overrides.
@@ -0,0 +1,43 @@ | |||
# __rllib-in-60s-begin__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script linked to from the documentation (new "RLlib in 60s" page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
"RLlib in 60sec" overhaul.
doc/source/rllib-index.rst
page (moved todoc/source/rllib/index.rst
)TODO: In a follow up PR, we'll add sigils to the "Feature Overview" section, such that each feature of RLlib (e.g. multi-agent) has its own sigil. These will then also be usable in the examples scripts- and other sections of the new documentation.
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.