Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; documentation] "RLlib in 60sec" overhaul. #20215

Merged
merged 9 commits into from
Nov 10, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 10, 2021

"RLlib in 60sec" overhaul.

  • Start moving rllib docs pages into "rllib" sub-folder (analogous to tune).
  • Re-do doc/source/rllib-index.rst page (moved to doc/source/rllib/index.rst)
  • Start moving code in the docs to their own "rllib/examples/documentation/" folder and CI-test all code snippets in the docs (this is work in progress). This PR tests the new example code in the "RLlib in 60sec" section.

TODO: In a follow up PR, we'll add sigils to the "Feature Overview" section, such that each feature of RLlib (e.g. multi-agent) has its own sigil. These will then also be usable in the examples scripts- and other sections of the new documentation.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@@ -318,8 +318,9 @@ Papers
:maxdepth: -1
:caption: Ray RLlib

rllib.rst
rllib/index.rst
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will start moving all rllib docs files into the rllib sub-folder to the rst's will no longer be in the top-leve directory. Analogous to how tune docs do this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@@ -0,0 +1,195 @@
.. admonition:: We're hiring!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new RLlib main index page.

@@ -40,6 +40,10 @@
# starting letter of the test name (e.g. "examples_A", or "tests_dir_F") for
# split-up purposes in buildkite.

# Note: There is a special directory in examples: "documentation" which contains
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start CI-testing any code snippet in the RLlib documentation.

@@ -749,8 +749,9 @@ def env_creator_from_classpath(env_context):
# Evaluation setup.
self.evaluation_workers = None
self.evaluation_metrics = {}
# Do automatic evaluation from time to time.
if self.config.get("evaluation_interval"):
# User would like to setup a separate evaluation worker set.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change in the code to make the new example (RLlib in 60s) work with fewer config-overrides.

@@ -0,0 +1,43 @@
# __rllib-in-60s-begin__
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script linked to from the documentation (new "RLlib in 60s" page)

Copy link
Contributor

@worldveil worldveil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sven1977 sven1977 merged commit ebd56b5 into ray-project:master Nov 10, 2021
@sven1977 sven1977 deleted the docs_rllib_in_60sec_overhaul branch June 2, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants