Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on using remote URIs for runtime environments #20352

Merged
merged 16 commits into from
Nov 18, 2021

Conversation

shrekris-anyscale
Copy link
Contributor

Why are these changes needed?

Feature #19862 allows users to specify dependencies accessed via remote URIs in their runtime_env dictionaries. These changes update the runtime_env documentation to teach users how to use remote URIs.

Related issue number

Closes #20340.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Documentation PR– no testing needed.

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! We'll use this as a model for expanding on the docs for the other runtime_env fields like conda.

doc/source/dependency-management.rst Outdated Show resolved Hide resolved

.. warning::

Check for hidden files in zipped dependencies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give a brief explanation or example for how to do this?


runtime_env = {..., "working_dir": "/some_path/example_dir", ...}

Suppose instead you want to host its contents remotely and provide a remote URI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Suppose instead you want to host its contents remotely and provide a remote URI.
Suppose instead you want to host your files remotely and provide a remote URI.

Comment on lines 158 to 159
You would need to first compress the ``example_dir`` directory into a zip file.
There should be no other files or directories at the top level of the zip file, other than ``example_dir``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to give a quick example of how to do this, like an example command or something?

@jvrdnd
Copy link
Contributor

jvrdnd commented Nov 16, 2021

My main feedback is for the URLs, it seems easier to tell people where to click/what to run to get the URLs rather than the structure of the URL (we can show both, but it's easier to point to how to get it rather than how to construct it). Otherwise lgtm!

@edoakes
Copy link
Contributor

edoakes commented Nov 16, 2021

Agree with @javi-redondo -- can we at least tell people how to get it for GitHub?

@architkulkarni
Copy link
Contributor

Can we rearrange things to the recommended link option appears before the non-recommended one? And within the recommended option, using HEAD is not recommended, so perhaps it should go last. Other than that, looks good!

fishbone pushed a commit that referenced this pull request Nov 19, 2021
wuisawesome pushed a commit that referenced this pull request Nov 20, 2021
wuisawesome pushed a commit that referenced this pull request Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[runtime_env] Document remote URI support
5 participants