[Rllib/release] Disable throughput check #20387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throughput check was enabled by d8a61f8 prematurely. E.g., see state before the commit: https://github.com/ray-project/ray/blob/a931076f59a993fc8c5c69d336650e253f087cc4/rllib/utils/test_utils.py#L740-L741
amogkam
approved these changes
Nov 15, 2021
|
test is kicked off here https://buildkite.com/ray-project/periodic-ci/builds/1646#_ |
amogkam
changed the title
|
|
wuisawesome
pushed a commit
that referenced
this pull request
Nov 20, 2021
Throughput check was enabled by d8a61f8 prematurely. E.g., see state before the commit: https://github.com/ray-project/ray/blob/a931076f59a993fc8c5c69d336650e253f087cc4/rllib/utils/test_utils.py#L740-L741
wuisawesome
pushed a commit
that referenced
this pull request
Nov 21, 2021
Throughput check was enabled by d8a61f8 prematurely. E.g., see state before the commit: https://github.com/ray-project/ray/blob/a931076f59a993fc8c5c69d336650e253f087cc4/rllib/utils/test_utils.py#L740-L741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughput check was enabled by d8a61f8 prematurely.
E.g., see state before the commit:
ray/rllib/utils/test_utils.py
Lines 740 to 741 in a931076
Why are these changes needed?
Disable throughput check that was accidentally enabled.
Good to know which Test still has significant performance gap though :)
Related issue number
Closes #20385
Checks
scripts/format.shto lint the changes in this PR.