[RLlib] Document and extend action mask example. #20390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 2, 2021 19:21
richardliaw
reviewed
Nov 16, 2021
richardliaw
reviewed
Nov 16, 2021
richardliaw
reviewed
Nov 16, 2021
|
nice work here ;) |
extra line breaks in comments Co-authored-by: Richard Liaw <[email protected]>
Extra line breaks in comments for better structure Co-authored-by: Richard Liaw <[email protected]>
Slightly adjusted comments Co-authored-by: Richard Liaw <[email protected]>
sven1977
approved these changes
Nov 16, 2021
| @@ -1,61 +1,129 @@ | |||
| """Example showing how to use "action masking" in RLlib. | |||
|
Waiting for tests, for merging ... |
sven1977
changed the title
sven1977
added
the
tests-ok
wuisawesome
pushed a commit
that referenced
this pull request
Nov 20, 2021
Co-authored-by: Richard Liaw <[email protected]> Co-authored-by: Sven Mika <[email protected]> Co-authored-by: sven1977 <[email protected]>
wuisawesome
pushed a commit
that referenced
this pull request
Nov 21, 2021
Co-authored-by: Richard Liaw <[email protected]> Co-authored-by: Sven Mika <[email protected]> Co-authored-by: sven1977 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds comments to document the action masking example.
Also extends the example to allow training manually without Ray tune.
And adding an option to disable masking, illustrating that invalid actions are indeed selection without masking.
Related issue number
Ongoing effort of improving and extending all examples.
Checks
scripts/format.shto lint the changes in this PR.