Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Trainer sub-class A2C/A3C (instead of build_trainer). #20635

Merged
merged 5 commits into from
Nov 24, 2021
Merged

[RLlib] Trainer sub-class A2C/A3C (instead of build_trainer). #20635

merged 5 commits into from
Nov 24, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 22, 2021 •
edited
Loading

Trainer sub-class A2C/A3C (instead of build_trainer).

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Nov 24, 2021
avnishn
avnishn approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sven1977 sven1977 merged commit c07d8c4 into ray-project:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnishn avnishn avnishn approved these changes

Assignees

@avnishn avnishn

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @avnishn