[jobs] Add headers field to JobSubmissionClient and apply to all requests #20663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
reviewed
Nov 23, 2021
There was a problem hiding this comment.
As discussed offline, let's unify this with the existing parse_cluster_info and have @nikitavemuri review!
|
cc: @nikitavemuri do you mind taking a look and see if this looks good for CLI for both surfaces ? |
…_add_header git pull
nikitavemuri
reviewed
Dec 2, 2021
dashboard/modules/job/sdk.py
Outdated
| @@ -27,10 +27,17 @@ class ClusterInfo: | |||
| address: str | |||
| cookies: Optional[Dict[str, Any]] | |||
| metadata: Optional[Dict[str, Any]] | |||
| headers: Optional[Dict[str, Any]] | |||
There was a problem hiding this comment.
Let's also give all additional fields a default value, so this still works if some modules are returning an older version of ClusterInfo.
…ion call signature
edoakes
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is needed in case user needs to connect with their internal cluster that requires authentication.
Closes #20595
Checks
scripts/format.shto lint the changes in this PR.