[tune] Enforce one future at a time for any given trial at any given time. #20783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang2010
force-pushed
the
find_item
branch
from
1472a44
to
5f51c1c
Compare
xwjiang2010
changed the title
krfricke
reviewed
Dec 1, 2021
Comment on lines
+590
to
+592
| assert len( | ||
| out | ||
| ) <= 1, "Expecting one future for any given trial at any given time." |
There was a problem hiding this comment.
Possibly unrelated to this PR: Should we rename this into find_training_future as we only use this helper to find futures in self._running?
There was a problem hiding this comment.
Yes, and instead of retuning a list, we should just return the item.
May do that separately tho. Want to first enforce this basic behavior first.
|
Added env variable for result throughput release tests. |
krfricke
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Also enforce disabling (instead of allowing user to override this) buffer training when
checkpoint_at_endis used.Related issue number
Checks
scripts/format.shto lint the changes in this PR.