Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] Fix assertion in test #20893

Merged
merged 1 commit into from
Dec 6, 2021
Merged

[train] Fix assertion in test #20893

merged 1 commit into from
Dec 6, 2021

Conversation

suquark
Copy link
Member

@suquark suquark commented Dec 5, 2021

Why are these changes needed?

The assertion is wrong. This causes python to assert a generator, which is always true.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

amogkam
amogkam approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, thanks!

@amogkam amogkam merged commit 3285bb6 into ray-project:master Dec 6, 2021
@suquark suquark deleted the fix_train_test branch December 6, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suquark @amogkam