Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core]Clear the unnecessary fields before broadcasting #20965

Merged
merged 2 commits into from
Jan 3, 2022
Merged

[Core]Clear the unnecessary fields before broadcasting #20965

merged 2 commits into from
Jan 3, 2022

Conversation

WangTaoTheTonic
Copy link
Contributor

Why are these changes needed?

Only resource_avaialbe and resource_total are used in raylet, so let's clear the rest before broadcasting.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Contributor

Can you merge the latest master?

@rkooo567 rkooo567 self-assigned this Dec 14, 2021
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 14, 2021
@WangTaoTheTonic
Copy link
Contributor Author

WangTaoTheTonic commented Dec 30, 2021 •
edited
Loading

test_client and test_runtime_env failed but seem unrelated.
@rkooo567 can you help to rerun them?

@WangTaoTheTonic WangTaoTheTonic removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 30, 2021
@rkooo567 rkooo567 merged commit b910648 into master Jan 3, 2022
@rkooo567 rkooo567 deleted the clear_fields branch January 3, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WangTaoTheTonic @rkooo567