-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFrame] Refactor GroupBy Methods and Implement Reindex #2101
Merged
devin-petersohn
merged 23 commits into
ray-project:master
from
kunalgosar:groupby_methods
May 22, 2018
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f8fd93a
fix 1D blocks case
kunalgosar bb2b761
Add groupby test code
kunalgosar 88e0919
begin writing tests
kunalgosar 58ad669
Fix bug on groupby(axis=1, ...)
kunalgosar c3511cf
implement reindex
kunalgosar d6337c9
fix index misalignment after groupby
kunalgosar f9db167
fix df.apply bug
kunalgosar 15cbef7
fix groupby.apply
kunalgosar f5cdf68
fix agg funcs
kunalgosar 5b6d1a3
finish groupby tests
kunalgosar 78fde91
finish test suite for groupby
kunalgosar 22ab723
fixing lint
kunalgosar 21abecb
undo new line
kunalgosar e5b1904
fix python2 index copy bug
kunalgosar 9a87026
Concat Series into ray.df
kunalgosar 54544cc
fixing python2 issues
kunalgosar 18645ed
resolving all python 2 tests
kunalgosar df5697e
handle multiindex on apply
kunalgosar fa5b540
resolve comments
kunalgosar ec18852
updating docstring
kunalgosar f211b46
fix lint
kunalgosar fed3294
fix lint again
kunalgosar a3722c6
address comments
kunalgosar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the
tuple([...] + block.tolist())
you can just do(...) + tuple(block.tolist())
. I think it seems more clear this way.