Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Issue 21109: Action unsquashing causes inf/NaN actions for unbounded action spaces. #21110

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 15, 2021

Issue 21109: Action unsquashing causes inf/NaN actions for unbounded action spaces.

Why are these changes needed?

Closes issue 21109

Related issue number

#21109

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 quick suggestion. thanks for the fix.

@sven1977
Copy link
Contributor Author

Thanks for the review! I can't find your suggestion, though :D

@gjoliver
Copy link
Member

Thanks for the review! I can't find your suggestion, though :D

ah, that's really weird!
I was saying maybe we should just keep using (s.dtype == np.float32 or s.dtype == np.float64).
using substring match for type check feels a bit hacky.
personal opinion 😆

Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate the fix!

@sven1977 sven1977 merged commit 35af30a into ray-project:master Jan 10, 2022
@sven1977 sven1977 deleted the issue_21109_action_unsquashing_in_unbounded_spaces branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants