Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/release] Update to recent anyscale API changes #21149

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Recent changes in the anyscale API rendered the current e2e script incompatible. This PR resolves these subtle API changes.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Contributor

Hey @krfricke do you know why it wasn't communicated to us? This is really bad some APIs have deprecated without us noticing it (and didn't have enough migration time).

@krfricke
Copy link
Contributor Author

I think there is no process in place to track this. Product is not aware of the APIs we're using. I think a solution will be, once we split up e2e.py, to run some unit tests on the product CI.

Copy link
Contributor

@nikitavemuri nikitavemuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work, but get_auth_api_client is not actually a public API either. Only imports under anyscale.sdk are considered public, so it would be good to eventually move to using those instead. It looks like session_controller is currently being used to call deprecated CLI commands (push, pull), so we should either add more functionality in the SDK or restructure the tests.

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kai!

@richardliaw
Copy link
Contributor

@alanwguo FYI

@alanwguo
Copy link
Contributor

@rkooo567, agreed. This shouldn't have happened like this.

  1. We will make sure to broadcast these changes more widely. The original email was sent out only to field team. The email has since been expanded to include oss-dev. We didn't expect users to be using these functions. This will hopefully prevent this from happening again.
  2. We have clarified in the anyscale docs what is considered public apis: The SDK functions are public to import and the CLI's terminal commands are public to use.

The anyscale CLI/SDK codebase is closed source. Because of this, we think it's reasonable to expect that only the things that are disclosed in our documentation are considered public apis.

Hopefully this won't be a problem in the future once the e2e tests are fully using public APIs.

@rkooo567
Copy link
Contributor

I see. This makes sense!

@krfricke do we have other private api use cases? Maybe just removing all of them asap would help us in the long term.

@krfricke
Copy link
Contributor Author

krfricke commented Jan 4, 2022

Merged master, test run here: https://buildkite.com/ray-project/periodic-ci/builds/2225

@krfricke krfricke merged commit aa35045 into ray-project:master Jan 4, 2022
@krfricke krfricke deleted the ci/anyscale-update branch January 4, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants