Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime env] [doc] [test] Add docs and tests for RAY_runtime_env_skip_local_gc environment variable #21163

Merged
merged 3 commits into from
Dec 20, 2021
Merged

[runtime env] [doc] [test] Add docs and tests for RAY_runtime_env_skip_local_gc environment variable #21163

merged 3 commits into from
Dec 20, 2021

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

This envrionment variable is a useful escape hatch for debugging if something goes wrong with garbage collection. It appears it wasn't documented or tested before.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo
Copy link
Contributor

`

FAILED

  | ::TestSkipLocalGC::test_skip_local_gc_env_var[no_ray_client-pip]


https://buildkite.com/ray-project/ray-builders-pr/builds/21163#fa054117-9078-49a2-b87c-93a53fe2bf53/1931-2789

@simon-mo simon-mo added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 18, 2021
@architkulkarni architkulkarni added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Dec 18, 2021
@architkulkarni
Copy link
Contributor Author

tests_pendulum_sac flaky on master, @simon-mo merge at will!

@simon-mo simon-mo merged commit 5cc1308 into ray-project:master Dec 20, 2021
@architkulkarni architkulkarni mentioned this pull request Feb 2, 2022
Closed
@architkulkarni architkulkarni deleted the skip-local-gc-docs-and-test branch February 2, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@jiaodong jiaodong

@simon-mo simon-mo

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@architkulkarni @simon-mo @jiaodong