Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] QMIX better defaults + added to CI learning tests #21332

Merged
merged 12 commits into from
Jan 4, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 2, 2022

  • Add QMIX learning tests (two_step_game) to CI for all available "mixers" (qmix, vdn, None).
  • Change QMIX default exploration config from final_epsilon=0.02 to 0.01 and epsilon_timesteps=10k to 40k. The new values are the RLlib original ones (had been changed with the introduction of the exploration API, when we switched to the default values of the EpsilonExploration class).
  • Made QMIX unit test more complex (2 agents grouped instead of just 1).

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 requested a review from gjoliver January 2, 2022 17:10
@sven1977 sven1977 changed the title [RLlib] QMIX learning regression [RLlib] QMIX better defaults + added to CI learning tests Jan 2, 2022
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. so the regression is just caused by hyper parameters?

timesteps_total: 70000
config:
# QMIX only supports torch for now.
framework: torch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try

frameworks: ["torch"] 

at the top level to only run these tests for torch?
I see that these new tests are failing because of framework tf.

@sven1977 sven1977 merged commit abd3bef into ray-project:master Jan 4, 2022
@sven1977 sven1977 deleted the qmix_learning_regression branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants