-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] QMIX better defaults + added to CI learning tests #21332
[RLlib] QMIX better defaults + added to CI learning tests #21332
Conversation
…_learning_regression
…_learning_regression
…_learning_regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. so the regression is just caused by hyper parameters?
timesteps_total: 70000 | ||
config: | ||
# QMIX only supports torch for now. | ||
framework: torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try
frameworks: ["torch"]
at the top level to only run these tests for torch?
I see that these new tests are failing because of framework tf.
…_learning_regression
…_learning_regression
final_epsilon
=0.02 to 0.01 andepsilon_timesteps
=10k to 40k. The new values are the RLlib original ones (had been changed with the introduction of the exploration API, when we switched to the default values of the EpsilonExploration class).Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.