Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Revert "Revert "updated pettingzoo wrappers, env versions, urls"" #21339

Merged
merged 5 commits into from
Jan 4, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 3, 2022

Reverts #21338

@sven1977
Copy link
Contributor Author

sven1977 commented Jan 3, 2022

Sorry @benblack769 , had to revert yesterday's merge again. Quick fix to our py3.6 build (adjusting the pettingzoo version for py<3.7 in requirements) should do ...

@@ -11,9 +11,10 @@ kaggle_environments==1.7.11
# Unity3D testing
mlagents_envs==0.27.0
# For tests on PettingZoo's multi-agent envs.
pettingzoo==1.11.1
pettingzoo==1.14.0; python_version >= '3.7'
pettingzoo==1.12.0; python_version < '3.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey sven, sorry I am still a bit confused, is there any point to install 1.12 for py3.6 at this point? given all the api updates in env/wrappers/pettingzoo_env.py?
does pettingzoo_env.py still work with 1.12? or should we just declare we don't support any versions under 1.14 now?

@sven1977
Copy link
Contributor Author

sven1977 commented Jan 4, 2022

Looking good now.
@gjoliver , I removed pettingzoo and supersuit requirements entirely for py<3.7 as you suggested. You are right, we will officially not support those for py3.6.

@sven1977
Copy link
Contributor Author

sven1977 commented Jan 4, 2022

@benblack769 , tests seem to be all passing now. Waiting for approval, then another merge-attempt (hopefully, the last :) )

@gjoliver
Copy link
Member

gjoliver commented Jan 4, 2022

one test error that may not be related. thanks man!

@sven1977 sven1977 merged commit c012457 into master Jan 4, 2022
@sven1977 sven1977 deleted the revert-21338-revert-20113-pettingzoo_upgrade2 branch January 4, 2022 17:30
@benblack769
Copy link
Contributor

@sven1977 Thanks for getting this merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants