-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Revert "Revert "updated pettingzoo wrappers, env versions, urls"" #21339
[RLlib] Revert "Revert "updated pettingzoo wrappers, env versions, urls"" #21339
Conversation
Sorry @benblack769 , had to revert yesterday's merge again. Quick fix to our py3.6 build (adjusting the pettingzoo version for py<3.7 in requirements) should do ... |
…rt-21338-revert-20113-pettingzoo_upgrade2
@@ -11,9 +11,10 @@ kaggle_environments==1.7.11 | |||
# Unity3D testing | |||
mlagents_envs==0.27.0 | |||
# For tests on PettingZoo's multi-agent envs. | |||
pettingzoo==1.11.1 | |||
pettingzoo==1.14.0; python_version >= '3.7' | |||
pettingzoo==1.12.0; python_version < '3.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey sven, sorry I am still a bit confused, is there any point to install 1.12 for py3.6 at this point? given all the api updates in env/wrappers/pettingzoo_env.py?
does pettingzoo_env.py still work with 1.12? or should we just declare we don't support any versions under 1.14 now?
Looking good now. |
@benblack769 , tests seem to be all passing now. Waiting for approval, then another merge-attempt (hopefully, the last :) ) |
one test error that may not be related. thanks man! |
@sven1977 Thanks for getting this merged in! |
Reverts #21338