Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Add test for heterogeneous resource request deadlocks #21397

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Jan 5, 2022

Why are these changes needed?

This adds a test for potential resource deadlocks in experiments with heterogeneous PGFs. If the PGF of a later trial becomes ready before that of a previous trial, we could run into a deadlock. This is currently avoided, but untested, flagging the code path for removal in #21387.

Related issue number

Closes #21387

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010
Copy link
Contributor

Thanks Kai. This is neat.

In the long term, we may want choose_trial_to_run(live_trials_of_pgf) like we discussed. has_resources_for_trial is not functioning any more.

@krfricke krfricke merged commit 976ece4 into ray-project:master Jan 6, 2022
@krfricke krfricke deleted the tune/test-het branch January 6, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants