[tune] Fix analysis without registered trainable #21475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdeng
reviewed
Jan 10, 2022
krfricke
requested changes
Jan 10, 2022
krfricke
requested changes
Jan 12, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes issues with loading
ExperimentAnalysisfrom path or pickle if the trainable used in the trials is not registered. Chiefly, it ensures that thestubattribute set inload_trials_from_experiment_checkpointdoesn't get overridden by the state of the loaded trial, and that when pickling, all trials inExperimentAnalysisare turned into stubs if they aren't already. A test has also been added.Related issue number
Closes #21212
Checks
scripts/format.shto lint the changes in this PR.