Tune test autoscaler / fix stale node detection bug #21516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 9, 2021 16:12
# Conflicts: # python/ray/autoscaler/_private/fake_multi_node/node_provider.py
# Conflicts: # .buildkite/pipeline.yml
# Conflicts: # python/ray/tune/tests/test_multinode_sync.py
Will add another test that kills node and see if the failure is caught.
xwjiang2010
force-pushed
the
tune/test-autoscaler
branch
from
2cd20cc
to
b11bf18
Compare
…/test-autoscaler
# Conflicts: # python/ray/autoscaler/_private/fake_multi_node/node_provider.py
…nto tune/test-autoscaler
xwjiang2010
changed the title
krfricke
commented
Jan 18, 2022
xwjiang2010
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #21458. Currently, Tune keeps its own list of alive node IPs, but this information is only updated every 10 seconds and is usually stale when a new node is added. Because of this, the first trial scheduled on this node is usually marked as failed. This PR adds a test confirming this behavior.
This PR should be updated to fix the issue. cc @xwjiang2010
Related issue number
This PR includes #20256 and requires it to be merged.
This tests #21458 and should be updated to close this issue.
Checks
scripts/format.shto lint the changes in this PR.