Fix SchedulingClassInfo.running_tasks memory leak #21535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
reviewed
Jan 12, 2022
ericl
added
the
@author-action-required
jjyao
removed
the
@author-action-required
ericl
added
the
@author-action-required
jjyao
removed
the
@author-action-required
ericl
reviewed
Jan 12, 2022
| @@ -280,7 +291,6 @@ class ClusterTaskManagerTest : public ::testing::Test { | |||
| ASSERT_TRUE(task_manager_.pinned_task_arguments_.empty()); | |||
| ASSERT_TRUE(task_manager_.info_by_sched_cls_.empty()); | |||
| ASSERT_EQ(task_manager_.pinned_task_arguments_bytes_, 0); | |||
There was a problem hiding this comment.
It's a duplicate line. See line 281.
ericl
added
the
@author-action-required
jjyao
added
tests-ok
ericl
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In some cases, the task that's added to the
running_tasksis never removed and introduces wait time for all the following tasks due to worker cap. One such case is lease request cancellation: the request is cancelled afterPopWorkeris called and the task is never removed fromrunning_tasks.Related issue number
Checks
scripts/format.shto lint the changes in this PR.