[RLlib] Discussion 4351: Conv2d default filter tests and add default setting for 96x96 image obs space. #21560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
added
the
tests-ok
avnishn
approved these changes
Jan 13, 2022
avnishn
reviewed
Jan 13, 2022
| 2, | ||
| MODEL_DEFAULTS.copy(), | ||
| framework=fw) | ||
| self.assertTrue( |
There was a problem hiding this comment.
How does the ModelCatalog know to retrieve a VisionNetwork or a TorchVision Network? There's nothing about the parameters of the function that indicate that we should be getting a vision ready network AFAICT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion 4351: Conv2d default filter tests and add default setting for 96x96 image obs space.
See also this discussion here:
https://discuss.ray.io/t/use-gym-wrappers-for-training/4351
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.