Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated streaming pb and pom files. #21851

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

ashione
Copy link
Member

@ashione ashione commented Jan 25, 2022

Why are these changes needed?

There are some auto-generated streaming files, which are not removed. This PR removes them totally.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jovany-wang
Copy link
Contributor

Could you check the .gitignore file? Maybe we should remove all streaming stuff from gitignore.

@ashione
Copy link
Member Author

ashione commented Jan 25, 2022

Could you check the .gitignore file? Maybe we should remove all streaming stuff from gitignore.

empty returns of git grep -i "streaming" .gitignore

@jovany-wang jovany-wang changed the title remove generated pb and pom files Remove generated streaming pb and pom files. Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants