Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nightly] Limit many drivers iteration to 4000 iterations #21958

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

fishbone
Copy link
Contributor

@fishbone fishbone commented Jan 28, 2022

Why are these changes needed?

Due to faster running of many drivers, we limit the iteration to 4k for the test.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a temporary solution? Or is the memory leak identified, and it is unsolveable?

@bveeramani
Copy link
Member

‼️ ACTION REQUIRED ‼️

We've switched our code formatter from YAPF to Black (see #21311).

To prevent issues with merging your code, here's what you'll need to do:

  1. Install Black
pip install -I black==21.12b0
  1. Format changed files with Black
curl -o format-changed.sh https://gist.githubusercontent.com/bveeramani/42ef0e9e387b755a8a735b084af976f2/raw/7631276790765d555c423b8db2b679fd957b984a/format-changed.sh
chmod +x ./format-changed.sh
./format-changed.sh
rm format-changed.sh
  1. Commit your changes.
git add --all
git commit -m "Format Python code with Black"
  1. Merge master into your branch.
git pull upstream master
  1. Resolve merge conflicts (if necessary).

After running these steps, you'll have the updated format.sh.

@fishbone
Copy link
Contributor Author

@rkooo567 yes, it is. I'll create another ticket to track the long-term updates.

@fishbone fishbone merged commit 0659d4a into ray-project:master Jan 31, 2022
@fishbone
Copy link
Contributor Author

fishbone commented Feb 1, 2022

@rkooo567 I created the issue here #22027
Should the dashboard be put into core backlog?

@rkooo567
Copy link
Contributor

rkooo567 commented Feb 1, 2022

Hmm I think we should probably track it for now and pass it to other teams once there's a clear owner for the dashboard?

I think removing memory leak should be a critical requirement for the ray core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants