-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train] Allow train
methods to be called outside of the session
#21969
Conversation
|
Just checking, this will allow it to be created inside Jupyter notebook, outside of a train run, correct? |
@worldveil yep thats right. |
Anything I can do to unblock here? |
… train-minor-docs-update
Comments are addressed, please take another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at failing tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM pending successful tests.
Failing tests are unrelated, going to merge. |
Update more examples to include the ray.train.torch import line. Follow up to #21969
…y-project#21969) Updates to address @worldveil's feedback: Include import train.torch in the docs Allow methods in session.py to be called outside of the session with sensible defaults. These will no longer raise an error. Co-authored-by: Balaji Veeramani <[email protected]>
Update more examples to include the ray.train.torch import line. Follow up to ray-project#21969
Updates to address @worldveil's feedback:
import train.torch
in the docssession.py
to be called outside of the session with sensible defaults. These will no longer raise an error.Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.