[RLlib] Add an env wrapper so RecSim works with our Bandits agent. #22028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
changed the title
sven1977
reviewed
Feb 2, 2022
sven1977
reviewed
Feb 2, 2022
sven1977
reviewed
Feb 2, 2022
| @@ -0,0 +1,55 @@ | |||
| """ Example of using LinUCB on a RecSim env. """ | |||
There was a problem hiding this comment.
Nice! Our backup for SlateQ ;)
sven1977
approved these changes
Feb 2, 2022
gjoliver
pushed a commit
to gjoliver/ray
that referenced
this pull request
Feb 9, 2022
…y work. Revert "[RLlib] Add an env wrapper so RecSim works with our Bandits agent. (ray-project#22028)" This reverts commit 9c95b9a.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Bandits now works with RecSim. Also adds an example script.
Learning isn't that stable though, I have seen runs that goes south. Need more testing probably.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.