[tune] Retry cloud sync up/down/delete on fail #22029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang2010
reviewed
Feb 1, 2022
| @@ -251,6 +256,7 @@ def __init__( | |||
| self.logfile = None | |||
| self._closed = False | |||
| self.cmd_process = None | |||
| self._last_cmd = None | |||
There was a problem hiding this comment.
Could we add a comment here what this is for?
xwjiang2010
approved these changes
Feb 1, 2022
|
Restart test runs? Now that the release test is fixed by you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Syncing of checkpoints to/from cloud storage or deleting them sometimes fails due to endpoint issues (i.e. AWS/GS communication). In these cases we usually want to retry the command as failures are often stochastic. This PR hopefully improves test rate of our durable upload release tests.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.