-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add K8s Builder Step #22035
[CI] Add K8s Builder Step #22035
Conversation
Hey, this is great! Some stupid questions:
|
The build step run inside a container. So we can't use minikube directly, minikube relies on virtual machine. We have already setup a docker-in-docker environment inside a separate container (hence the mentioning of dind). This PR runs kind inside that environment and allow the host container (where build steps run) talk to the the K8s api server. It's a bit crazy but basically we have the following architecture The kind cluster should be able to use containers from that dind nodes if we configure local registry https://kind.sigs.k8s.io/docs/user/local-registry/, I'll probably do it in a separate PR. There isn't any limit for the CPU or memory capacity, but in the end the whole thing is running on a single VM. We can run it on a bigger box though. |
Actually we can use |
Cool, got it (mostly). Which container does the test code run in? |
The left hand side host container
Node port should work as long as you use |
This PR configures kind to allow kubectl to connect to it. This is a prerequisite for testing sample YAML files end-to-end in Buildkite. The configuration is copied from @simon-mo's work in ray-project/ray#22035. --------- Signed-off-by: Archit Kulkarni <[email protected]>
This PR configures kind to allow kubectl to connect to it. This is a prerequisite for testing sample YAML files end-to-end in Buildkite. The configuration is copied from @simon-mo's work in ray-project/ray#22035. --------- Signed-off-by: Archit Kulkarni <[email protected]>
This PR configures kind to allow kubectl to connect to it. This is a prerequisite for testing sample YAML files end-to-end in Buildkite. The configuration is copied from @simon-mo's work in ray-project/ray#22035. --------- Signed-off-by: Archit Kulkarni <[email protected]>
Why are these changes needed?
This PR bring in a kind cluster with our current CI infra and verify it works.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.