[tune/wandb] Fix WandbTrainableMixin config for rllib trainables #22063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yard1
approved these changes
Feb 2, 2022
|
Can we test for this? |
xwjiang2010
approved these changes
Feb 3, 2022
added 2 commits
February 3, 2022 07:53
|
Unfortunately does not solve the issue, but may provide a workaround (to be tested) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The WandbTrainableMixin doesn't work with RLLib trainables as they won't recognize the
wandbparameter. Thus we should pop the wandb config before we initialize the rest of the trainable.Related issue number
Checks
scripts/format.shto lint the changes in this PR.