[RLlib] Issue 22036: Client should handle concurrent episodes with one being training_enabled=False.
#22076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_22036_client_handles_concurrent_episodes
sven1977
changed the title
training_enabled=False.training_enabled=False.
2 tasks
gjoliver
approved these changes
Feb 4, 2022
| @@ -172,7 +172,7 @@ def log_action( | |||
| def log_returns( | |||
| self, | |||
| episode_id: str, | |||
| reward: int, | |||
| reward: float, | |||
| @@ -0,0 +1,88 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
should we add this as a unit test?
There was a problem hiding this comment.
Oh yes, I think I forgot this! Let me check. Great catch. It's working though, I checked on my laptop :D
…e_22036_client_handles_concurrent_episodes
…e_22036_client_handles_concurrent_episodes
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
…e being `training_enabled=False`. (ray-project#22076)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 22036: Client should handle concurrent episodes with one being
training_enabled=False.Why are these changes needed?
Issue #22036
Related issue number
Closes #22036
Checks
scripts/format.shto lint the changes in this PR.