[Autoscaler] make --redis-address not required
#22083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
approved these changes
Feb 3, 2022
DmitriGekhtman
approved these changes
Feb 3, 2022
|
(I mean modify to not pass "redis-address" to the monitor entry-point) |
mwtian
added
the
tests-ok
|
The test_dataset failure looks unrelated. |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
`--redis-address` should not be required, since starting autoscaler with `--gcs-address` is supported too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
--redis-addressshould not be required, since starting autoscaler with--gcs-addressis supported too.Related issue number
Checks
scripts/format.shto lint the changes in this PR.