Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train] Fix accuracy calculation for CIFAR example #22292

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[Train] Fix accuracy calculation for CIFAR example #22292

merged 1 commit into from
Feb 10, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Feb 10, 2022

Same as #21689 except for cifar

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

matthewdeng
matthewdeng approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@amogkam amogkam merged commit 09e4606 into ray-project:master Feb 10, 2022
@amogkam amogkam deleted the train-cifar-example-fix branch February 10, 2022 23:06
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
@amogkam @simonsays1980
[Train] Fix accuracy calculation for CIFAR example (ray-project#22292)
37a06c2 
Same as ray-project#21689 except for cifar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees

@matthewdeng matthewdeng

@Yard1 Yard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amogkam @matthewdeng @Yard1