Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add example commands for using setup-dev.py with RLlib for improved dev setup stability and developer experience. #22380

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

gjoliver
Copy link
Member

@gjoliver gjoliver commented Feb 15, 2022

Why are these changes needed?

Add example command-lines for using setup-dev.py to do RLlib dev work.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjoliver !

@sven1977
Copy link
Contributor

Awesome. Fixed some LINT issues. Waiting for tests to pass ...

@sven1977 sven1977 self-assigned this Feb 15, 2022
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 15, 2022
@sven1977 sven1977 changed the title Add example commands for using setup-dev.py [RLlib] Add example commands for using setup-dev.py with RLlib for improved dev setup stability and developer experience. Feb 15, 2022
@sven1977 sven1977 merged commit b729a93 into ray-project:master Feb 15, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
…improved dev setup stability and developer experience. (ray-project#22380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants