Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] Force local metadata resolution when unserializable Partitioning object provided. #22477

Merged
merged 3 commits into from
Feb 19, 2022
Merged

[Datasets] Force local metadata resolution when unserializable Partitioning object provided. #22477

merged 3 commits into from
Feb 19, 2022

Conversation

clarkzinzow
Copy link
Contributor

pa.dataset.Partitioning objects aren't serializable, so we need to force local metadata resolution when such objects are given as read_parquet() args.

Related issue number

Closes #22453

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarkzinzow clarkzinzow changed the title [Datasets] Force local metadata resolution when unserializable partitioning object provided. [Datasets] Force local metadata resolution when unserializable Partitioning object provided. Feb 17, 2022
@clarkzinzow clarkzinzow mentioned this pull request Feb 17, 2022
Closed
2 tasks
ericl
ericl reviewed Feb 17, 2022
View reviewed changes
python/ray/data/read_api.py Outdated Show resolved Hide resolved
python/ray/data/read_api.py Show resolved Hide resolved
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 17, 2022
@clarkzinzow clarkzinzow added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Feb 19, 2022
@clarkzinzow
Copy link
Contributor Author

Datasets tests are ok, should be ready to merge.

@ericl ericl merged commit 76e8247 into ray-project:master Feb 19, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
@clarkzinzow @simonsays1980
[Datasets] Force local metadata resolution when unserializable `Parti…
aff8f1b 
…tioning` object provided. (ray-project#22477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scv119 scv119 Awaiting requested review from scv119

@ericl ericl Awaiting requested review from ericl

Assignees

@ericl ericl

@scv119 scv119

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
3 participants
@clarkzinzow @ericl @scv119