Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[RLlib] Enable Bandits to work in batches mode(s) (vector env… #22497

Closed

Conversation

rkooo567
Copy link
Contributor

…s + multiple workers + train_batch_sizes > 1). (#22465)"

This reverts commit c58cd90.

Why are these changes needed?

Seems to break test output
Screen Shot 2022-02-18 at 4 49 14 AM

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…s + multiple workers + train_batch_sizes > 1). (ray-project#22465)"

This reverts commit c58cd90.
@rkooo567
Copy link
Contributor Author

@iycheng can you merge if it verifies to fix a bug? There's a possibility the root cause is different too

@gjoliver
Copy link
Member

hey @rkooo567, @iycheng already tried it last night, this PR is not causing the failure.
something else happened to change at the same time.

@rkooo567 rkooo567 closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants