[aws][autoscaler] fix regional default AMI's #22506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckw017
changed the title
| ami_src_info[key] = "dlami" | ||
| if not default_ami: | ||
| cli_logger.abort( | ||
| f"Node type `{key}` does not have an ImageId and no default " |
There was a problem hiding this comment.
To slightly reduce cognitive load, let's express in this message that ImageId is a subfield of nodeConfig.
|
Thanks, @ckw017! |
DmitriGekhtman
approved these changes
Feb 25, 2022
DmitriGekhtman
added
the
@author-action-required
|
lmk when it's ready to merge |
ckw017
added
tests-ok
|
@DmitriGekhtman good to merge |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The AMI's for
ray.head.defaultandray.worker.defaultindefaults.yamlsupersede the default AMI for the region (defaults get merged in before_check_amiis called, causes problems if region isn'tus-west-2). Removes the default AMI from defaults.yaml, and aborts if user doesn't specify an AMI in a region without a default.Related issue number
Checks
scripts/format.shto lint the changes in this PR.