Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix typo in vector_env docstring #22534

Merged
merged 1 commit into from
Feb 22, 2022
Merged

[RLlib] Fix typo in vector_env docstring #22534

merged 1 commit into from
Feb 22, 2022

Conversation

jjyyxx
Copy link
Contributor

@jjyyxx jjyyxx commented Feb 22, 2022

Why are these changes needed?

Previous docstring about vector_env's observation_space is wrong.

Related issue number

Checks

(Not applicable)

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • (Not )I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

gjoliver
gjoliver approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing this.
@sven1977, can you please merge?

sven1977
sven1977 approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jjyyxx !

@sven1977 sven1977 merged commit 49d7ba3 into ray-project:master Feb 22, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
@jjyyxx @simonsays1980
[RLlib] Fix typo in vector_env docstring (ray-project#22534)
f6ab391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

@sven1977 sven1977 sven1977 approved these changes

@avnishn avnishn Awaiting requested review from avnishn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyyxx @sven1977 @gjoliver