-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] SlateQ: Add a hard-task learning test to weekly regression suite. #22544
[RLlib] SlateQ: Add a hard-task learning test to weekly regression suite. #22544
Conversation
# Conflicts: # rllib/agents/slateq/slateq.py
…eq_torch_cleanups # Conflicts: # .buildkite/pipeline.ml.yml # rllib/BUILD # rllib/agents/slateq/slateq.py # rllib/agents/slateq/slateq_tf_model.py # rllib/agents/slateq/slateq_tf_policy.py # rllib/agents/slateq/slateq_torch_model.py # rllib/agents/slateq/slateq_torch_policy.py # rllib/agents/slateq/tests/test_slateq.py # rllib/tuned_examples/slateq/interest-evolution-10-candidates-recsim-env-slateq.yaml # rllib/tuned_examples/slateq/interest-evolution-50-candidates-recsim-env-slateq.yaml # rllib/tuned_examples/slateq/interest-evolution-recsim-env-slateq.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR probably included diffs from the other slateq torch PR.
might want to rebase then merge after the other PR is in.
@@ -5,7 +5,7 @@ | |||
- RLLIB_TESTING=1 PYTHON=3.7 ./ci/travis/install-dependencies.sh | |||
- bazel test --config=ci $(./scripts/bazel_export_options) | |||
--build_tests_only | |||
--test_tag_filters=learning_tests_discrete,-fake_gpus,-torch_only,-tf2_only | |||
--test_tag_filters=learning_tests_discrete,-fake_gpus,-torch_only,-tf2_only,-no_tf_static_graph |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just curious about these tags. where can I use them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are defined in the rllib/BUILD
file. You can make up any tags and filter by these on the BAZEL command line.
You are right, some diffs need to be merged first. ... |
SlateQ: Add a hard-task learning test to weekly regression suite.
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.