Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] SlateQ: Add a hard-task learning test to weekly regression suite. #22544

Merged
merged 41 commits into from
Feb 25, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Feb 22, 2022

SlateQ: Add a hard-task learning test to weekly regression suite.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

# Conflicts:
#	rllib/agents/slateq/slateq.py
…eq_torch_cleanups

# Conflicts:
#	.buildkite/pipeline.ml.yml
#	rllib/BUILD
#	rllib/agents/slateq/slateq.py
#	rllib/agents/slateq/slateq_tf_model.py
#	rllib/agents/slateq/slateq_tf_policy.py
#	rllib/agents/slateq/slateq_torch_model.py
#	rllib/agents/slateq/slateq_torch_policy.py
#	rllib/agents/slateq/tests/test_slateq.py
#	rllib/tuned_examples/slateq/interest-evolution-10-candidates-recsim-env-slateq.yaml
#	rllib/tuned_examples/slateq/interest-evolution-50-candidates-recsim-env-slateq.yaml
#	rllib/tuned_examples/slateq/interest-evolution-recsim-env-slateq.yaml
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR probably included diffs from the other slateq torch PR.
might want to rebase then merge after the other PR is in.

@@ -5,7 +5,7 @@
- RLLIB_TESTING=1 PYTHON=3.7 ./ci/travis/install-dependencies.sh
- bazel test --config=ci $(./scripts/bazel_export_options)
--build_tests_only
--test_tag_filters=learning_tests_discrete,-fake_gpus,-torch_only,-tf2_only
--test_tag_filters=learning_tests_discrete,-fake_gpus,-torch_only,-tf2_only,-no_tf_static_graph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just curious about these tags. where can I use them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are defined in the rllib/BUILD file. You can make up any tags and filter by these on the BAZEL command line.

@sven1977
Copy link
Contributor Author

You are right, some diffs need to be merged first. ...

@sven1977 sven1977 merged commit 7b687e6 into ray-project:master Feb 25, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
@sven1977 sven1977 deleted the slateq_hard_task_regression branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants