[RLlib] Issue 22625: MultiAgentBatch.timeslices() does not behave as expected.
#22657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver and
avnishn
as code owners
|
Can we add a small test to prove that this does the fixes that you're attempting to make? |
gjoliver
approved these changes
Mar 5, 2022
sven1977
changed the title
MultiAgentBatch.timeslices() does not behave as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
MultiAgentBatch.timeslices() does not behave as expected. I returns non-information-batches for later slices and does not do the same for earlier slices.
timeit tells me that
cur_slice.clear()is quicker thancur_slice = collections.defaultdict(SampleBatchBuilder).Related issue number
Closes #22625
Checks
scripts/format.shto lint the changes in this PR.