Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix tree.flatten dict ordering bug: flatten_space([obs_space]) should produce same struct as tree.flatten([obs]). #22731

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Mar 1, 2022

Fix tree.flatten dict ordering bug: flatten_space([obs_space]) should produce same struct as tree.flatten([obs]).

Simple reproduction of the issue:

from gym.spaces import Dict, Discrete
from ray.rllib.utils.space_utils import flatten_space
import tree  # dm_tree

space = Dict({"b": Discrete(200), "a": Discrete(1)})
flattened_spaces = flatten_space(space)
# flattened_spaces.spaces = [Discrete(200), Discrete(1)]  <- sorts dict keys by order of insertion!

flat_sample = tree.flatten(space.sample())
# flat_sample = [50, 0]  <- sorts dict keys by alphabet(!)

The above discrepancy could lead to mismatches (even unnoticed) when complex spaces are used, e.g. in our default ComplexInputNets (for tf and torch).

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome change.
thanks for the comments, and also fixing my dataset input bug.

@sven1977 sven1977 merged commit 0af100f into ray-project:master Mar 1, 2022
@sven1977 sven1977 deleted the fix_tree_flatten_dict_sorting_bug branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants