Make a pass fixing Dataset API issues #22886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyao
reviewed
Mar 8, 2022
| @@ -507,8 +507,6 @@ def random_shuffle( | |||
| *, | |||
| seed: Optional[int] = None, | |||
| num_blocks: Optional[int] = None, | |||
| _spread_resource_prefix: Optional[str] = None, | |||
There was a problem hiding this comment.
@scv119 Have we confirmed with Uber that they no longer need _spread_resource_prefix?
jjyao
reviewed
Mar 8, 2022
ericl
added
the
tests-ok
clarkzinzow
approved these changes
Mar 8, 2022
| A list of references to this dataset's blocks. | ||
| """ | ||
| return self._plan.execute().get_blocks() | ||
|
|
||
| def _experimental_lazy(self) -> "Dataset[T]": |
There was a problem hiding this comment.
Should we de-experimentalize lazy evaluation before GA?
There was a problem hiding this comment.
Good question. I'm leaning towards no, given that we have read task fusion enabled at least, and most of the critical use cases involve pipelines. But we can revisit based on user needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This fixes the following issues: