[serve] Implement serve.run() and Application
#23157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Edward Oakes <[email protected]>
shrekris-anyscale
changed the title
run public APIserve.run() and Application
shrekris-anyscale
removed
the
@author-action-required
edoakes
reviewed
Mar 17, 2022
python/ray/serve/api.py
Outdated
| """ | ||
| return cls.from_dict(yaml.safe_load(str_or_file)) | ||
|
|
||
| def get_ingress(self) -> Optional[Deployment]: |
There was a problem hiding this comment.
can you update this to be:
@property
def ingress(self):
...to match the docstring and the deployments interface?
There was a problem hiding this comment.
I updated it.
edoakes
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These changes expose
Applicationas a public API. They also introduce a new public method,serve.run(), which allows users to deploy theirApplicationsorDeploymentNodes. Additionally, the Serve CLI'sruncommand and Serve's REST API are updated to useApplicationsandserve.run().Related issue number
Resolves parts of #23137, #23138, #23139.
Checks
scripts/format.shto lint the changes in this PR.